AP_Periph: add node visual locate function #29844
Open
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
reviewed
Apr 30, 2025
| last_led_ms = now; | ||
|
|
||
| #ifdef HAL_GPIO_PIN_LED | ||
| static uint32_t last_led_ms; |
Contributor
There was a problem hiding this comment.
Could we drop this into a flash_led method, please?
| static uint32_t next_led_ms = 1000; | ||
| if (now - last_led_ms > next_led_ms) { | ||
| last_led_ms = now; | ||
| if (!no_iface_finished_dna) { |
Contributor
There was a problem hiding this comment.
Doesn't this mean the code will be non-functional, depending on whether it has dna'd or not?
|
|
||
| #ifdef HAL_GPIO_PIN_LED | ||
| static uint32_t last_led_ms; | ||
| static uint32_t next_led_ms = 1000; |
Contributor
There was a problem hiding this comment.
Suggested change
| static uint32_t next_led_ms = 1000; | |
| static uint32_t current_led_interval_ms = 1000; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a new function to AP_Periph. If a heartbeat LED is defined, with set Bit 3 in AP_Periph DEBUG parameter a fast LED flash pattern will make it possible to visual locate the node quick.This can be used to locate the node in your hardware setup if you have more than one DroneCAN node in your setup.
Related to my old PR which I have closed now: #23503